Skip to content

enable annotations for playlab, add clearRuntimeAnnotations()#4273

Merged
cpirich merged 1 commit into
stagingfrom
playlab_annotations
Sep 30, 2015
Merged

enable annotations for playlab, add clearRuntimeAnnotations()#4273
cpirich merged 1 commit into
stagingfrom
playlab_annotations

Conversation

@cpirich

@cpirich cpirich commented Sep 30, 2015

Copy link
Copy Markdown
Contributor
  • annotationList was not set up for playlab, it is now
  • modified annotationList to keep track of lintAnnotations separately from runtimeAnnotations. added a clearRuntimeAnnotations function to reset the latter list only. added calls to that new function inside execute() for applab and playlab. This fixes an issue where runtime errors from your previous run attempt may still show in your gutter even after you fixed them.

@Bjvanminnen

Copy link
Copy Markdown
Contributor

lgtm

cpirich added a commit that referenced this pull request Sep 30, 2015
enable annotations for playlab, add clearRuntimeAnnotations()
@cpirich cpirich merged commit 61b0b53 into staging Sep 30, 2015
@cpirich cpirich deleted the playlab_annotations branch September 30, 2015 21:40
deploy-code-org added a commit that referenced this pull request Sep 30, 2015
commit 61b0b53
Merge: e5b2318 c115392
Author: Chris Pirich <chris@code.org>
Date:   Wed Sep 30 14:40:35 2015 -0700

    Merge pull request #4273 from code-dot-org/playlab_annotations

    enable annotations for playlab, add clearRuntimeAnnotations()

commit e5b2318
Merge: aad7706 d3089ea
Author: Will Jordan <wjordan@users.noreply.github.com>
Date:   Wed Sep 30 14:28:56 2015 -0700

    Merge pull request #4267 from code-dot-org/session_key

    Refactor environment-specific session key and storage_id cookie constants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants