Skip to content

Drop survey_answers table and related code#40932

Merged
daynew merged 1 commit into
stagingfrom
ha/drop-survey-answers
Jun 23, 2021
Merged

Drop survey_answers table and related code#40932
daynew merged 1 commit into
stagingfrom
ha/drop-survey-answers

Conversation

@hacodeorg

@hacodeorg hacodeorg commented Jun 3, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

FND-1584. This is a follow-up of #40683.

Drop survey_answers table since it's no longer needed. Also remove bin/cron/process_jotform_data, the only script that still has references to the survey_answers table. process_jotform_data script is not referenced anywhere.

@hacodeorg hacodeorg requested review from a team and bencodeorg June 3, 2021 01:58
@hacodeorg hacodeorg marked this pull request as ready for review June 3, 2021 01:58
@hacodeorg hacodeorg force-pushed the ha/drop-survey-answers branch from 864b335 to ecab6ec Compare June 4, 2021 00:55
@hacodeorg

hacodeorg commented Jun 4, 2021

Copy link
Copy Markdown
Contributor Author

@clareconstantine Since Ben is out, could you take a look at this PR also?

@bencodeorg

bencodeorg commented Jun 7, 2021

Copy link
Copy Markdown
Contributor

Thanks for doing this Ha! Two notes:

  1. This is maybe marginally outside the scope of this work, but could you also drop the survey_questions table here? They're both dropped/recreated in the script you're deleting, and I'm afraid if we don't do it now we'll never do it.
  2. Maybe you're already on this, but we should delete the copies of these tables that exist in Redshift as well after you do this.

bencodeorg
bencodeorg reviewed Jun 8, 2021
View reviewed changes

@bencodeorg bencodeorg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment with a couple of general notes -- looks like Ha will be out for a while, so might need someone else to push this through if we need to get it done in the next few weeks.

@daynew

daynew commented Jun 23, 2021

Copy link
Copy Markdown
Member

Maybe you're already on this, but we should delete the copies of these tables that exist in Redshift as well after you do this.

Yeah I can do this

@daynew daynew requested a review from bencodeorg June 23, 2021 18:05
@daynew daynew force-pushed the ha/drop-survey-answers branch from b35a37e to b744446 Compare June 23, 2021 18:15
@daynew daynew merged commit 74e625d into staging Jun 23, 2021
@daynew daynew deleted the ha/drop-survey-answers branch June 23, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bencodeorg bencodeorg bencodeorg approved these changes

@clareconstantine clareconstantine Awaiting requested review from clareconstantine

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hacodeorg @bencodeorg @daynew