Skip to content

Make lesson extras flag match bubble choice behavior #3#40530

Merged
cforkish merged 3 commits into
stagingfrom
cforkish/LP-1512-lesson-extras-flag
May 14, 2021
Merged

Make lesson extras flag match bubble choice behavior #3#40530
cforkish merged 3 commits into
stagingfrom
cforkish/LP-1512-lesson-extras-flag

Conversation

@cforkish

Copy link
Copy Markdown
Contributor

this PR reintroduces #40036 after eyes tests failed due to use of URLSearchParams which our current polyfill doesn't support. the only functional changes since that PR are in the second commit.

@cforkish cforkish requested review from a team and clareconstantine May 11, 2021 23:56

@clareconstantine clareconstantine left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Charlie!

@cforkish cforkish merged commit 4592b03 into staging May 14, 2021
@cforkish cforkish deleted the cforkish/LP-1512-lesson-extras-flag branch May 14, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants