Skip to content

no text decoration on buttons#3509

Merged
tanyaparker merged 1 commit into
stagingfrom
strayunderscore
Aug 12, 2015
Merged

no text decoration on buttons#3509
tanyaparker merged 1 commit into
stagingfrom
strayunderscore

Conversation

@tanyaparker

Copy link
Copy Markdown
Contributor

No description provided.

tanyaparker added a commit that referenced this pull request Aug 12, 2015
@tanyaparker tanyaparker merged commit 3bf61c6 into staging Aug 12, 2015
@tanyaparker tanyaparker deleted the strayunderscore branch August 12, 2015 21:36
deploy-code-org added a commit that referenced this pull request Aug 12, 2015
commit 836a717
Merge: 1788d65 0cde9b9
Author: Bjvanminnen <Bjvanminnen@gmail.com>
Date:   Wed Aug 12 15:06:04 2015 -0700

    Merge pull request #3252 from code-dot-org/hackedLevels

    custom type for play lab ninja cat

commit 1788d65
Merge: 65b860e 7f669b3
Author: Brian Jordan <bcjordan@gmail.com>
Date:   Wed Aug 12 15:04:13 2015 -0700

    Merge pull request #3512 from code-dot-org/fix_example_buttons_ie11

    [Finishes #101164984] Fix pressing example add/run buttons on IE11.

commit 0cde9b9
Author: Brent Van Minnen <bjvanminnen@gmail.com>
Date:   Tue Jul 28 10:07:44 2015 -0700

    custom type for play lab ninja cat

commit 7f669b3
Author: Brian Jordan <bcjordan@gmail.com>
Date:   Wed Aug 12 15:03:42 2015 -0700

    [Finishes #101164984] Fix example add/run buttons on IE11.

commit 65b860e
Merge: fef04cd 99c5650
Author: Bjvanminnen <Bjvanminnen@gmail.com>
Date:   Wed Aug 12 15:00:49 2015 -0700

    Merge pull request #3501 from code-dot-org/examplesOnClose

    [Finishes #99188090] Examples on close

commit fef04cd
Merge: 5fce434 550c909
Author: philbogle <phil@code.org>
Date:   Wed Aug 12 14:59:45 2015 -0700

    Merge pull request #3511 from code-dot-org/revert-3492-netsim-viz-performance-cleanup

    Revert "NetSim: Viz performance cleanup"

commit 550c909
Author: philbogle <phil@code.org>
Date:   Wed Aug 12 14:59:01 2015 -0700

    Revert "NetSim: Viz performance cleanup"

commit 5fce434
Merge: 6677a1d e6d07ba
Author: philbogle <phil@code.org>
Date:   Wed Aug 12 14:57:14 2015 -0700

    Merge pull request #3492 from code-dot-org/netsim-viz-performance-cleanup

    NetSim: Viz performance cleanup

commit 6677a1d
Author: Continuous Integration <dev@code.org>
Date:   Wed Aug 12 21:47:41 2015 +0000

    Automatically built.

    commit a4aefe4
    Merge: 3848999 89a2f53
    Author: Brian Jordan <bcjordan@gmail.com>
    Date:   Wed Aug 12 14:33:20 2015 -0700

        Merge pull request #3508 from code-dot-org/ignore_clicks_drawn_ui

        Ignore clicks on SVG-drawn UI elements to allow panning through them.

    commit 89a2f53
    Author: Brian Jordan <bcjordan@gmail.com>
    Date:   Wed Aug 12 14:31:06 2015 -0700

        Rename svgIgnoreMouse [ci skip]

    commit 96647d1
    Author: Brian Jordan <bcjordan@gmail.com>
    Date:   Wed Aug 12 14:20:51 2015 -0700

        Ignore clicks on SVG-drawn UI elements to allow panning through them.
        - Rename callText to callResult text to be more accurate (result also uses it)
        - Add helper for adding pointer events for SVG elements

commit 99c5650
Author: Brent Van Minnen <bjvanminnen@gmail.com>
Date:   Wed Aug 12 14:37:17 2015 -0700

    finish bad rebase

commit 3bf61c6
Merge: a4aefe4 0300263
Author: Tanya Parker <tanya@code.org>
Date:   Wed Aug 12 14:36:46 2015 -0700

    Merge pull request #3509 from code-dot-org/strayunderscore

    no text decoration on buttons

commit 9d6c0bc
Author: Brent Van Minnen <bjvanminnen@gmail.com>
Date:   Wed Aug 12 14:34:21 2015 -0700

    fix UI test

commit 56c2f28
Author: Brent Van Minnen <bjvanminnen@gmail.com>
Date:   Wed Aug 12 13:33:17 2015 -0700

    code review feedback

commit bc16af5
Author: Brent Van Minnen <bjvanminnen@gmail.com>
Date:   Wed Aug 12 12:49:14 2015 -0700

    consolidate some common code
@breville

Copy link
Copy Markdown
Member

Looks good. I've never really understood why this has been necessary, but we've used it on our site for a long time in any places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants