Promote Dance 2019 on /congrats #32256
Merged
Merged
Conversation
maddiedierker
approved these changes
Dec 3, 2019
breville
approved these changes
Dec 3, 2019
breville
left a comment
Member
There was a problem hiding this comment.
Assuming this means that all links to dance-2019 now have updated images, then this is great.
maddiedierker
approved these changes
Dec 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few changes to the promotional card sets on studio.code.org/congrats:
1.) We've been sending people to last year's dance party, so I updated the link to
/s/dance-2019/reset2.) Signed in users in English, now regardless of age, who complete an 'other' tutorial (anything except the Minecrafts, Dance, Dance 2019 or AppLab) will now see Dance 2019 instead of AppLab
3.) Signed out users who complete an 'other' tutorial will now see Dance 2019 instead of AppLab
