PL: some emails now get a Twitter share link#28024
Merged
Merged
Conversation
clareconstantine
approved these changes
Apr 15, 2019
| for additional resources and opportunities to connect with other computer science educators. | ||
|
|
||
| %p | ||
| = render partial: 'twitter_share' |
There was a problem hiding this comment.
Quick clarification - this is the email we send to confirm that we received their application, but it does not mean they have been accepted. Do we want to use the same text in the tweet "I just signed up for Code.org's Professional Learning Program" if they haven't been accepted yet?
Member
Author
There was a problem hiding this comment.
Good catch. Yes, this was discussed and approved.
|
@breville a few mismatches I see from the screenshots above:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A link to generate a tweet is added to these three emails.
Confirmation of teacher application
Accepted - no cost registration
Registration sent