Skip to content

PL: some emails now get a Twitter share link#28024

Merged
breville merged 3 commits into
stagingfrom
pl-emails-get-twitter-share-link
Apr 16, 2019
Merged

PL: some emails now get a Twitter share link#28024
breville merged 3 commits into
stagingfrom
pl-emails-get-twitter-share-link

Conversation

@breville

@breville breville commented Apr 15, 2019

Copy link
Copy Markdown
Member

A link to generate a tweet is added to these three emails.

Confirmation of teacher application

Screenshot 2019-04-16 09 19 55

Accepted - no cost registration

Screenshot 2019-04-16 09 19 48

Registration sent

Screenshot 2019-04-16 09 20 10

for additional resources and opportunities to connect with other computer science educators.

%p
= render partial: 'twitter_share'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick clarification - this is the email we send to confirm that we received their application, but it does not mean they have been accepted. Do we want to use the same text in the tweet "I just signed up for Code.org's Professional Learning Program" if they haven't been accepted yet?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Yes, this was discussed and approved.

@agealy

agealy commented Apr 15, 2019

Copy link
Copy Markdown

@breville a few mismatches I see from the screenshots above:

  1. The titles and bodies don't align with what I see in this google doc. Employee Engagement basics: Create code.org/company-profiles/* landing page #1 and update code-dot-org README #3 seem to be swapped. "Confirmation of teacher application" should describe the email where we are confirming receipt, but not acceptance. "Registration sent" should confirm acceptance and provide registration links. I want to make double sure that we aren't swapping the send conditions of these emails.
  2. The "registration sent" body (should be"Confirmation of teacher application") should read "Finally, help us spread the word in a tweet to encourage more teachers to join your local CS teaching community. Thank you for supporting computer science for all!" instead of "Congratulations and thanks for bringing computer science to your students! Help us spread the word in a tweet to encourage more teachers to join your local CS teaching community. Thank you for supporting computer science for all!"
  3. The "confirmation of teacher application body (should be "registration sent") final paragraph should read "Congratulations and thanks for bringing computer science to your students! Help us spread the word in a tweet to encourage more teachers to join your local CS teaching community. We look forward to receiving your registration as soon as possible, but no later than 5 days."

@breville breville merged commit f691865 into staging Apr 16, 2019
@breville breville deleted the pl-emails-get-twitter-share-link branch April 16, 2019 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants