Install nodejs on daemon for building apps packages#19411
Merged
Conversation
fix non-idempotent bug
754eb75 to
da99d73
Compare
Contributor
Author
|
heads up @islemaster |
[ci skip]
20492ac to
55a5332
Compare
Contributor
Author
|
manually ran the following to update cookbooks for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the cdo-apps cookbook to install nodejs on daemon instances configured to build apps packages.
Currently, the build logic is hard-coded to
staging/testenvironments. We can extract this to a common configuration in the future, for now I've duplicated the logic just to fix the issue preventing daemon instances from launching in these environments.