DOTD script: Create deploy candidate branch without switching to it#15425
Merged
Conversation
Contributor
|
Changes lgtm. Is there some steps you wanted me to take to verify today? |
Contributor
Author
|
Not necessarily, just wanted to give you a heads-up in case you wanted this change for your DTP today. You should be able to safely DTP with the current script too, as long as nobody's doing anything on test while we DTP (which means technically we should keep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to solve an issue I encountered as Dev-of-the-Day yesterday:
I started DTT #3, and shortly thereafter started a DTP from DTT #2's green commit using the DOTD script (which creates a deploy candidate branch for you). When DTT #3 reached eyes tests, I was surprised to find that the applitools dashboard reported that it was testing the deploy candidate branch, and was trying to compare it against staging baselines (very old):
It looks like the DOTD script actually used the test machine to create the candidate branch and left it checked out there - when I SSH'd into test at the end of the day and it was on
dtp_candidate_1183fa3dand I had to change it back manually.In this change to the script it still uses
testto create and push the deploy candidate branch, but it does so without ever actually switching to that branch. This should avoid what happened to DTT#3 yesterday.