Fix isTouching()#11277
Merged
Merged
Conversation
islemaster
commented
Oct 20, 2016
| }); | ||
|
|
||
| it('does not affect the location or velocity of the sprite', function () { | ||
| it('does not affect the location of the sprite', function () { |
Contributor
Author
There was a problem hiding this comment.
This test's name said it checked that velocity was not modified, but the test itself only checked positions 😁 which explains how this slipped through the cracks before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression in the behavior of
Sprite.isTouching()introduced by #11212. While the regression is live, it's easily illustrated by this demo: https://studio.code.org/projects/gamelab/J2-3Jb08SuAioE9pwQcyJA/viewI'd forgotten that our
Sprite.isTouching()does not actually alias p5.play'sSprite.overlap, but was changed in #9702 to callSprite.collide()with an extra argument that skips changes to position or velocity, to take advantage of the better tunneling code incollide(). Here I'm simply respecting that extra argument. I think we can eventually remove it, but I want to fix the regression first.