Improve load times on script edit page#10730
Closed
balderdash wants to merge 2 commits into
Closed
Conversation
61d111b to
de0b9c2
Compare
Contributor
|
I wonder if we can kill the list of levels entirely on this page? Maybe worth a quick question to level builders of whether or not they even use this list. Otherwise LGTM! |
Contributor
Author
|
Closing in favor of #10748 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two easy improvements:
link_tois slower than writing your own anchor tags (according to http://stackoverflow.com/a/5684467,link_totries to find the shortest url by examining available routes). Changing the level lists to use%ainstead oflink_toimproved loading time (on my machine, for /s/grade3/edit) from ~15s to ~8s.selectclause to the queries used to generate those level lists to only grabidandname. That further reduced load times from ~8s to ~3.5s.