Skip to content

Tests for GitHub.Sync.installation_event/1#1380

Merged
begedin merged 7 commits into
developfrom
chore/test-pull-request-event
Mar 24, 2018
Merged

Tests for GitHub.Sync.installation_event/1#1380
begedin merged 7 commits into
developfrom
chore/test-pull-request-event

Conversation

@zacck-zz
Copy link
Copy Markdown
Member

@zacck-zz zacck-zz commented Feb 28, 2018 •
edited by code-corps Bot
Loading

What's in this PR?

Adding test coverage for the GitHub.Sync.installation_event/1

References

Fixes #1373

Progress on: #

@zacck-zz
Copy link
Copy Markdown
Member Author

zacck-zz commented Feb 28, 2018

Struggling to test some validation clauses, however, seeking some help testing for the following clauses

{:error, :validating_github_issue, Changeset.t()}
{:error, :validating_user, Changeset.t()}
{:error, :multiple_issue_users_match}

@zacck-zz zacck-zz force-pushed the chore/test-pull-request-event branch from 5240b54 to f821630 Compare March 2, 2018 09:58
begedin
begedin requested changes Mar 13, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@begedin begedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some extra stuff you forgot to remove and then it's good to merge. 👍

Comment thread test/lib/code_corps/github/sync/sync_test.exs



end
Copy link
Copy Markdown
Contributor

@begedin begedin Mar 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably meant to remove this part.

Copy link
Copy Markdown
Member Author

@zacck-zz zacck-zz Mar 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha yes I did

@zacck-zz
Copy link
Copy Markdown
Member Author

zacck-zz commented Mar 16, 2018

Ok done!!

@zacck-zz zacck-zz force-pushed the chore/test-pull-request-event branch from 01ea6f8 to 4c20f68 Compare March 16, 2018 16:36
@zacck-zz
Copy link
Copy Markdown
Member Author

zacck-zz commented Mar 16, 2018 •
edited
Loading

@begedin ok ✂️ done!

@zacck-zz zacck-zz changed the title [WIP]Tests for GitHub.Sync.installation_event/1 Tests for GitHub.Sync.installation_event/1 Mar 19, 2018
@begedin begedin merged commit e8520c6 into develop Mar 24, 2018
@begedin begedin deleted the chore/test-pull-request-event branch March 24, 2018 08:25
@begedin
Copy link
Copy Markdown
Contributor

begedin commented Mar 24, 2018

@zacck As usual, thank you for your time, work and expertise. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@begedin begedin begedin approved these changes

Assignees

No one assigned

Labels

needs code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zacck-zz @begedin @zacck