feat: Add unmanaged sources by yevgenypats · Pull Request #677 · cloudquery/plugin-sdk

yevgenypats · 2023-02-12T11:07:00Z

Used in this postgres source - cloudquery/cloudquery#7835

Usually used in database sources

github-actions · 2023-02-12T11:09:41Z

⏱️ Benchmark results

Comparing with 8e8f5fe

DefaultConcurrencyDFS-2 resources/s: 11,120 ⬆️ 4.20% increase vs. 8e8f5fe
DefaultConcurrencyRoundRobin-2 resources/s: 12,155 ⬆️ 2.68% increase vs. 8e8f5fe
Glob-2 ns/op: 192.4 ⬇️ 34.62% decrease vs. 8e8f5fe
TablesWithChildrenDFS-2 resources/s: 28,931 ⬆️ 8.43% increase vs. 8e8f5fe
TablesWithChildrenRoundRobin-2 resources/s: 27,120 ⬆️ 10.21% increase vs. 8e8f5fe
TablesWithRateLimitingDFS-2 resources/s: 28.35 ⬇️ 0.28% decrease vs. 8e8f5fe
TablesWithRateLimitingRoundRobin-2 resources/s: 824.2 ⬇️ 6.94% decrease vs. 8e8f5fe
BufferedScanner-2 ns/op: 9.382 ⬇️ 20.98% decrease vs. 8e8f5fe
LogReader-2 ns/op: 30.99 ⬇️ 18.62% decrease vs. 8e8f5fe

codecov-commenter · 2023-02-12T11:10:14Z

Codecov Report

Base: 47.23% // Head: 46.55% // Decreases project coverage by -0.69% ⚠️

Coverage data is based on head (e1cf405) compared to base (879f843).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
- Coverage   47.23%   46.55%   -0.69%     
==========================================
  Files          70       55      -15     
  Lines        6815     5411    -1404     
==========================================
- Hits         3219     2519     -700     
+ Misses       3146     2531     -615     
+ Partials      450      361      -89

Impacted Files	Coverage Δ
schema/meta.go	`10.00% <ø> (ø)`
plugins/source/options.go
plugins/source/plugin.go
serve/enum.go
plugins/source/scheduler.go
plugins/source/metrics.go
serve/source.go
plugins/source/scheduler_dfs.go
plugins/source/scheduler_round_robin.go
plugins/source/docs.go
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [1.37.0](v1.36.3...v1.37.0) (2023-02-13) ### Features * Add unmanaged sources ([#677](#677)) ([f3e2b1d](f3e2b1d)) ### Bug Fixes * Fix race in dest testing try 3 ([#683](#683)) ([8e8f5fe](8e8f5fe)) * Make sure _cq_id unique across all dest plugins ([#685](#685)) ([a9a1173](a9a1173)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…7933) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/cloudquery/plugin-sdk](https://togithub.com/cloudquery/plugin-sdk) | require | patch | `v1.36.1` -> `v1.37.0` | | [github.com/cloudquery/plugin-sdk](https://togithub.com/cloudquery/plugin-sdk) | require | patch | `v1.36.0` -> `v1.37.0` | --- ### Release Notes <details> <summary>cloudquery/plugin-sdk</summary> ### [`v1.37.0`](https://togithub.com/cloudquery/plugin-sdk/releases/tag/v1.37.0) [Compare Source](https://togithub.com/cloudquery/plugin-sdk/compare/v1.36.3...v1.37.0) ##### Features * Add unmanaged sources ([#677](cloudquery/plugin-sdk#677)) ([f3e2b1d](cloudquery/plugin-sdk@f3e2b1d)) ##### Bug Fixes * Fix race in dest testing try 3 ([#683](cloudquery/plugin-sdk#683)) ([8e8f5fe](cloudquery/plugin-sdk@8e8f5fe)) * Make sure _cq_id unique across all dest plugins ([#685](cloudquery/plugin-sdk#685)) ([a9a1173](cloudquery/plugin-sdk@a9a1173)) ## [1.36.3](cloudquery/plugin-sdk@v1.36.2...v1.36.3) (2023-02-12) ### [`v1.36.3`](https://togithub.com/cloudquery/plugin-sdk/releases/tag/v1.36.3) [Compare Source](https://togithub.com/cloudquery/plugin-sdk/compare/v1.36.2...v1.36.3) ##### Bug Fixes - Take2 of fixing race in destination testing ([#680](https://togithub.com/cloudquery/plugin-sdk/issues/680)) ([77b74b2](https://togithub.com/cloudquery/plugin-sdk/commit/77b74b2cd4c28ee5f570b008105a41d0b7e8afc8)) ### [`v1.36.2`](https://togithub.com/cloudquery/plugin-sdk/releases/tag/v1.36.2) [Compare Source](https://togithub.com/cloudquery/plugin-sdk/compare/v1.36.1...v1.36.2) ##### Bug Fixes - Potential database lock/race in destination testing ([#678](https://togithub.com/cloudquery/plugin-sdk/issues/678)) ([50e683e](https://togithub.com/cloudquery/plugin-sdk/commit/50e683e7f6dfd38a25eb512c1e2417798fa832f7)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

…(#7933) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/cloudquery/plugin-sdk](https://togithub.com/cloudquery/plugin-sdk) | require | patch | `v1.36.1` -> `v1.37.0` | | [github.com/cloudquery/plugin-sdk](https://togithub.com/cloudquery/plugin-sdk) | require | patch | `v1.36.0` -> `v1.37.0` | --- ### Release Notes <details> <summary>cloudquery/plugin-sdk</summary> ### [`v1.37.0`](https://togithub.com/cloudquery/plugin-sdk/releases/tag/v1.37.0) [Compare Source](https://togithub.com/cloudquery/plugin-sdk/compare/v1.36.3...v1.37.0) ##### Features * Add unmanaged sources ([#677](cloudquery/plugin-sdk#677)) ([f3e2b1d](cloudquery/plugin-sdk@f3e2b1d)) ##### Bug Fixes * Fix race in dest testing try 3 ([#683](cloudquery/plugin-sdk#683)) ([8e8f5fe](cloudquery/plugin-sdk@8e8f5fe)) * Make sure _cq_id unique across all dest plugins ([#685](cloudquery/plugin-sdk#685)) ([a9a1173](cloudquery/plugin-sdk@a9a1173)) ## [1.36.3](cloudquery/plugin-sdk@v1.36.2...v1.36.3) (2023-02-12) ### [`v1.36.3`](https://togithub.com/cloudquery/plugin-sdk/releases/tag/v1.36.3) [Compare Source](https://togithub.com/cloudquery/plugin-sdk/compare/v1.36.2...v1.36.3) ##### Bug Fixes - Take2 of fixing race in destination testing ([#680](https://togithub.com/cloudquery/plugin-sdk/issues/680)) ([77b74b2](https://togithub.com/cloudquery/plugin-sdk/commit/77b74b2cd4c28ee5f570b008105a41d0b7e8afc8)) ### [`v1.36.2`](https://togithub.com/cloudquery/plugin-sdk/releases/tag/v1.36.2) [Compare Source](https://togithub.com/cloudquery/plugin-sdk/compare/v1.36.1...v1.36.2) ##### Bug Fixes - Potential database lock/race in destination testing ([#678](https://togithub.com/cloudquery/plugin-sdk/issues/678)) ([50e683e](https://togithub.com/cloudquery/plugin-sdk/commit/50e683e7f6dfd38a25eb512c1e2417798fa832f7)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

feat: Add unmanaged sources

d6787f5

Usually used in database sources

yevgenypats requested review from erezrokah and hermanschaaf February 12, 2023 11:07

github-actions Bot added the feat label Feb 12, 2023

erezrokah approved these changes Feb 12, 2023

View reviewed changes

Comment thread plugins/source/plugin.go Outdated

yevgenypats and others added 2 commits February 13, 2023 10:30

Update plugins/source/plugin.go

e1cf405

Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>

fix review

f3ca524

yevgenypats marked this pull request as ready for review February 13, 2023 08:35

Merge branch 'main' into feat/unmanaged_source

519e439

erezrokah approved these changes Feb 13, 2023

View reviewed changes

yevgenypats added the automerge label Feb 13, 2023

kodiakhq Bot merged commit f3e2b1d into main Feb 13, 2023

kodiakhq Bot deleted the feat/unmanaged_source branch February 13, 2023 08:45

cq-bot mentioned this pull request Feb 13, 2023

chore(main): Release v1.37.0 #684

Merged

erezrokah mentioned this pull request Feb 13, 2023

fix(deps): Update module github.com/cloudquery/plugin-sdk to v1.37.0 cloudquery/cloudquery#7933

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add unmanaged sources#677

feat: Add unmanaged sources#677
kodiakhq[bot] merged 4 commits into
mainfrom
feat/unmanaged_source

yevgenypats commented Feb 12, 2023

Uh oh!

github-actions Bot commented Feb 12, 2023 •

edited

Loading

Uh oh!

codecov-commenter commented Feb 12, 2023 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

yevgenypats commented Feb 12, 2023

Uh oh!

github-actions Bot commented Feb 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏱️ Benchmark results

Uh oh!

codecov-commenter commented Feb 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Feb 12, 2023 •

edited

Loading

codecov-commenter commented Feb 12, 2023 •

edited

Loading