Skip to content

fix(destination): Rename NewDestinationPlugin to NewPlugin #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 1 commit into from
Dec 19, 2022
Merged

fix(destination): Rename NewDestinationPlugin to NewPlugin #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/destination/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ type Plugin struct {

const writeWorkers = 1

func NewDestinationPlugin(name string, version string, newDestinationClient NewClientFunc) *Plugin {
func NewPlugin(name string, version string, newDestinationClient NewClientFunc) *Plugin {
p := &Plugin{
name: name,
version: version,
Expand Down
8 changes: 4 additions & 4 deletions plugins/destination/plugin_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ import (
)

func TestPlugin(t *testing.T) {
p := NewDestinationPlugin("test", "development", NewTestDestinationMemDBClient)
p := NewPlugin("test", "development", NewTestDestinationMemDBClient)
PluginTestSuiteRunner(t, p, nil,
TestSuiteTests{})
}

func TestOnNewError(t *testing.T) {
ctx := context.Background()
p := NewDestinationPlugin("test", "development", newTestDestinationMemDBClientErrOnNew)
p := NewPlugin("test", "development", newTestDestinationMemDBClientErrOnNew)
err := p.Init(ctx, getTestLogger(t), specs.Destination{})

if err == nil {
Expand All @@ -29,7 +29,7 @@ func TestOnNewError(t *testing.T) {
func TestOnWriteError(t *testing.T) {
ctx := context.Background()
newClientFunc := getNewTestDestinationMemDBClient(withErrOnWrite())
p := NewDestinationPlugin("test", "development", newClientFunc)
p := NewPlugin("test", "development", newClientFunc)
if err := p.Init(ctx, getTestLogger(t), specs.Destination{}); err != nil {
t.Fatal(err)
}
Expand All @@ -56,7 +56,7 @@ func TestOnWriteError(t *testing.T) {
func TestOnWriteCtxCancelled(t *testing.T) {
ctx := context.Background()
newClientFunc := getNewTestDestinationMemDBClient(withBlockingWrite())
p := NewDestinationPlugin("test", "development", newClientFunc)
p := NewPlugin("test", "development", newClientFunc)
if err := p.Init(ctx, getTestLogger(t), specs.Destination{}); err != nil {
t.Fatal(err)
}
Expand Down
2 changes: 1 addition & 1 deletion serve/destination_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func bufDestinationDialer(context.Context, string) (net.Conn, error) {
}

func TestDestination(t *testing.T) {
plugin := destination.NewDestinationPlugin("testDestinationPlugin", "development", destination.NewTestDestinationMemDBClient)
plugin := destination.NewPlugin("testDestinationPlugin", "development", destination.NewTestDestinationMemDBClient)
s := &destinationServe{
plugin: plugin,
}
Expand Down