Skip to content

fix: Add better logging/metric per table #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 3 commits into from
Dec 18, 2022
Merged

fix: Add better logging/metric per table #513

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05f1988
fix: Add better logging/metric per table
yevgenypats Dec 17, 2022
d3eb8c6
call fmt
yevgenypats Dec 17, 2022
55af7e3
Update plugins/source_scheduler_dfs.go
yevgenypats Dec 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions plugins/source/scheduler_dfs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,24 @@ func (p *Plugin) syncDfs(ctx context.Context, spec specs.Source, client schema.C
wg.Wait()
}

func (p *Plugin) logTablesMetrics(tables schema.Tables, client schema.ClientMeta) {
clientName := client.ID()
for _, table := range tables {
metrics := p.metrics.TableClient[table.Name][clientName]
p.logger.Info().Str("table", table.Name).Str("client", clientName).Uint64("resources", metrics.Resources).Uint64("errors", metrics.Errors).Msg("table sync finished")
p.logTablesMetrics(table.Relations, client)
}
}

func (p *Plugin) resolveTableDfs(ctx context.Context, table *schema.Table, client schema.ClientMeta, parent *schema.Resource, resolvedResources chan<- *schema.Resource, depth int) {
clientName := client.ID()
logger := p.logger.With().Str("table", table.Name).Str("client", clientName).Logger()

if parent == nil { // Log only for root tables, otherwise we spam too much.
logger.Info().Msg("table resolver started")
logger.Info().Msg("top level table resolver started")
}

tableMetrics := p.metrics.TableClient[table.Name][clientName]

res := make(chan interface{})
go func() {
defer func() {
Expand All @@ -109,8 +118,9 @@ func (p *Plugin) resolveTableDfs(ctx context.Context, table *schema.Table, clien
}

// we don't need any waitgroups here because we are waiting for the channel to close
if parent == nil { // Log only for root tables, otherwise we spam too much.
logger.Info().Uint64("resources", tableMetrics.Resources).Uint64("errors", tableMetrics.Errors).Msg("fetch table finished")
if parent == nil { // Log only for root tables and relations only after resolving is done, otherwise we spam per object instead of per table.
logger.Info().Uint64("resources", tableMetrics.Resources).Uint64("errors", tableMetrics.Errors).Msg("table sync finished")
p.logTablesMetrics(table.Relations, client)
}
}

Expand Down