Skip to content

chore: Add more govet lint rules #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 1 commit into from
Aug 2, 2024
Merged

chore: Add more govet lint rules #1849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ linters-settings:
- var
- func
disable-dec-order-check: false
govet:
enable-all: true
disable:
- fieldalignment
- shadow

revive:
enable-all-rules: true
Expand Down
4 changes: 1 addition & 3 deletions internal/servers/destination/v0/schemav2tov3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ func ColumnV2ToV3(column schemav2.Column) schema.Column {
}

func TypeV2ToV3(dataType schemav2.ValueType) arrow.DataType {
var typ arrow.DataType

switch dataType {
case schemav2.TypeBool:
return arrow.FixedWidthTypes.Boolean
Expand Down Expand Up @@ -94,7 +92,7 @@ func TypeV2ToV3(dataType schemav2.ValueType) arrow.DataType {
case schemav2.TypeMacAddrArray:
return arrow.ListOf(types.ExtensionTypes.MAC)
default:
panic("unknown type " + typ.Name())
panic("unknown type " + dataType.String())
}
}

Expand Down