fix: Better build overrides#1492
Merged
Merged
Conversation
disq
reviewed
Jan 29, 2024
disq
approved these changes
Jan 29, 2024
Member
disq
left a comment
There was a problem hiding this comment.
How about adding Tags to BuildTarget?
Contributor
Author
I think we'll add them when we'll really need them 😃 |
erezrokah
approved these changes
Jan 29, 2024
kodiakhq Bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
🤖 I have created a release *beep* *boop* --- ## [4.27.2](v4.27.1...v4.27.2) (2024-01-29) ### Bug Fixes * Better build overrides ([#1492](#1492)) ([ca5afc1](ca5afc1)) * When `_cq_id` SyncMigrateMessage not sent ([#1489](#1489)) ([d177320](d177320)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq Bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of passing
staticoption we should allow for env var values overrides in the package call.