Skip to content

fix(github): Use cursor-based sync for github_repository_dependabot_alerts #9554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 3 commits into from
Apr 3, 2023
Merged

fix(github): Use cursor-based sync for github_repository_dependabot_alerts #9554

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5862df6
use cursor-based sync for dependabot
candiduslynx Mar 31, 2023
02a6eb4
Update plugins/source/github/resources/services/organizations/alerts.go
candiduslynx Mar 31, 2023
19876db
Merge branch 'main' into fix/pk/github_repository_dependabot_alerts
kodiakhq[bot] Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
use cursor-based sync for dependabot
  • Loading branch information
@candiduslynx
candiduslynx committed Mar 31, 2023
commit 5862df64ab37c917baad4310c05d079aac59c0ca
2 changes: 1 addition & 1 deletion plugins/source/github/resources/services/organizations/alerts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ func fetchAlerts(ctx context.Context, meta schema.ClientMeta, _ *schema.Resource
}
res <- alerts
opts.After = resp.After
if resp.After == "" {
if len(opts.After) == 0 {
Comment thread
candiduslynx marked this conversation as resolved.
Outdated
break
}
}
Expand Down
5 changes: 2 additions & 3 deletions plugins/source/github/resources/services/repositories/alerts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package repositories

import (
"context"
"strconv"

"github.com/cloudquery/cloudquery/plugins/source/github/client"
"github.com/cloudquery/plugin-sdk/schema"
Expand Down Expand Up @@ -30,8 +29,8 @@ func fetchAlerts(ctx context.Context, meta schema.ClientMeta, parent *schema.Res
return err
}
res <- alerts
opts.Page = strconv.FormatInt(int64(resp.NextPage), 10)
if resp.NextPage == 0 {
opts.After = resp.After
if len(resp.After) == 0 {
Comment thread
candiduslynx marked this conversation as resolved.
break
}
}
Expand Down