chore(website): Update Docs to show information for new Destination Spec option#9257
Conversation
erezrokah
left a comment
There was a problem hiding this comment.
Some comments, and we should wait to merge this after we do all the releases. Great work on this feature 🚀
| ### pk_mode | ||
| <!-- vale on --> | ||
|
|
||
| (`string`, optional, default: `default`, Available: `default`, `cq-id-only` introduced in CLI `v2.5.2`) |
There was a problem hiding this comment.
I think this should say introduced in all destinations released after <date> too no? Users will need both the new CLI and latest destinations correct?
There was a problem hiding this comment.
agreed, while I think that using as a reference point is probably the best thing we can do right now, I think we need a better way of documenting compatibility between CLI, config and plugins
There was a problem hiding this comment.
Ah, we have the same issue with https://www.cloudquery.io/docs/reference/source-spec#deterministic_cq_id
There was a problem hiding this comment.
Updated. Added a similar note to the source spec as well
erezrokah
left a comment
There was a problem hiding this comment.
I'm a bit confused with the current wording of the date phrase
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Summary
document
pk_modeattribute in destination specRelies on #9169