fix(github)!: Change github_organization_dependabot_alerts PK from (org,number) to (org,html_url)#8070
Merged
Conversation
This PR has the following changes to source plugin(s) tables:
|
erezrokah
approved these changes
Feb 14, 2023
shimonp21
approved these changes
Feb 14, 2023
shimonp21
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍
but maybe keep the relational-table names uppercase, as in the other plugins?
Member
I think it's good to make them private so they are not mistakly added to the top level tables. We had a few cases before: |
hermanschaaf
approved these changes
Feb 14, 2023
… to `(org,html_url)`
9a31301 to
ec9d833
Compare
kodiakhq Bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
🤖 I have created a release *beep* *boop* --- ## [4.0.0](plugins-source-github-v3.0.1...plugins-source-github-v4.0.0) (2023-02-21) ### ⚠ BREAKING CHANGES * **github:** Remove `repository` column from `github_workflows` * **github:** Change `github_organization_dependabot_alerts` PK from `(org,number)` to `(org,html_url)` ([#8070](#8070)) ### Features * **github-resources:** Add Traffic resources ([#8085](#8085)) ([cc22f56](cc22f56)) * **github:** Add repositories multiplexer ([#8074](#8074)) ([f5f874d](f5f874d)) * **github:** Handle secondary rate limit ([#8078](#8078)) ([bf1f1cc](bf1f1cc)) * **github:** Remove `repository` column from `github_workflows` ([21905a4](21905a4)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.38.2 ([#8156](#8156)) ([ac2d2d7](ac2d2d7)) * **deps:** Update module golang.org/x/net to v0.7.0 [SECURITY] ([#8176](#8176)) ([fc4cef8](fc4cef8)) * **github:** Add `repository_id` to `github_workflows` PK ([21905a4](21905a4)) * **github:** Change `github_organization_dependabot_alerts` PK from `(org,number)` to `(org,html_url)` ([#8070](#8070)) ([a7c64cd](a7c64cd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/cloudquery/cloudquery-issues/issues/482
Based on https://docs.github.com/en/rest/dependabot/alerts?apiVersion=2022-11-28#get-a-dependabot-alert.