Skip to content

fix(aws)!: PK for aws_s3_bucket_grants #7822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 3 commits into from
Feb 8, 2023
+9 −3
Merged

fix(aws)!: PK for aws_s3_bucket_grants #7822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbadd94
Update aws_s3_bucket_grants.md
bbernays Feb 8, 2023
4f5207e
Update bucket_grants.go
bbernays Feb 8, 2023
70982f3
Merge branch 'main' into aws_s3_bucket_grants
kodiakhq[bot] Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/source/aws/docs/tables/aws_s3_bucket_grants.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

https://docs.aws.amazon.com/AmazonS3/latest/API/API_Grant.html

The composite primary key for this table is (**bucket_arn**, **grantee_type**, **grantee_id**).
The composite primary key for this table is (**bucket_arn**, **grantee_type**, **grantee_id**, **permission**).

## Relations

Expand All @@ -20,5 +20,5 @@ This table depends on [aws_s3_buckets](aws_s3_buckets.md).
|bucket_arn (PK)|String|
|grantee_type (PK)|String|
|grantee_id (PK)|String|
|grantee|JSON|
|permission|String|
|permission (PK)|String|
|grantee|JSON|
6 changes: 6 additions & 0 deletions plugins/source/aws/resources/services/s3/bucket_grants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,12 @@ func BucketGrants() *schema.Table {
Resolver: resolveBucketGranteeID,
CreationOptions: schema.ColumnCreationOptions{PrimaryKey: true},
},
{
Name: "permission",
Type: schema.TypeString,
Resolver: schema.PathResolver("Permission"),
CreationOptions: schema.ColumnCreationOptions{PrimaryKey: true},
},
},
}
}