Skip to content

feat(scaffold): Add Makefile and test workflow to scaffold, and flesh out readme #7118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 5 commits into from
Jan 25, 2023
Merged

feat(scaffold): Add Makefile and test workflow to scaffold, and flesh out readme #7118

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b6f201
Add Makefile and test workflow to scaffold, and flesh out readme
hermanschaaf Jan 24, 2023
5dad96b
Use official golangci
hermanschaaf Jan 25, 2023
399470a
Apply suggestions from code review
hermanschaaf Jan 25, 2023
8cc2557
Apply suggestions from code review
hermanschaaf Jan 25, 2023
fa6e8c2
Merge branch 'main' into add-files-to-scaffold
kodiakhq[bot] Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use official golangci
  • Loading branch information
@hermanschaaf
hermanschaaf authored Jan 25, 2023
commit 5dad96b1c77192055698a643410c695ff01bd647
4 changes: 2 additions & 2 deletions scaffold/cmd/templates/source/.github/workflows/test.yaml.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
cache: true
cache-dependency-path: go.sum
Comment thread
hermanschaaf marked this conversation as resolved.
Outdated
- name: golangci-lint
uses: cloudquery/golangci-lint-action@master
uses: golangci/golangci-lint-action@v3
with:
version: v1.50.1
args: "--config .golangci.yml"
Expand All @@ -40,4 +40,4 @@ jobs:
run: make gen
- name: Fail if generation updated files
if: github.event_name == 'pull_request'
run: test "$(git status -s | wc -l)" -eq 0 || (git status -s; exit 1)
run: test "$(git status -s | wc -l)" -eq 0 || (git status -s; exit 1)