Skip to content

feat(gcp-resources): Add AppEngine resources #5972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erezrokah merged 5 commits into from
Dec 29, 2022
Merged

feat(gcp-resources): Add AppEngine resources #5972

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f1600f
feat(gcp-resources): Add AppEngine resources
erezrokah Dec 26, 2022
712aa0a
fix: Lint
erezrokah Dec 26, 2022
51dc5ff
refactor: Remove ServiceDNS
erezrokah Dec 28, 2022
c5d47c5
chore: Clean up list functions
erezrokah Dec 29, 2022
3a5e69a
Merge branch 'main' into feat/gcp_app_engine
erezrokah Dec 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Lint
  • Loading branch information
@erezrokah
erezrokah committed Dec 29, 2022
commit 712aa0a5463b1ff96f8fd8d78862eaac92f6834b
2 changes: 1 addition & 1 deletion plugins/source/gcp/resources/services/appengine/apps_mock_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type fakeAppsServer struct {
pb.UnimplementedApplicationsServer
}

func (f *fakeAppsServer) GetApplication(context.Context, *pb.GetApplicationRequest) (*pb.Application, error) {
func (*fakeAppsServer) GetApplication(context.Context, *pb.GetApplicationRequest) (*pb.Application, error) {
resp := pb.Application{}
if err := faker.FakeObject(&resp); err != nil {
return nil, fmt.Errorf("failed to fake data: %w", err)
Expand Down
6 changes: 3 additions & 3 deletions plugins/source/gcp/resources/services/appengine/services_mock_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ type fakeServicesServer struct {
pb.UnimplementedServicesServer
}

func (f *fakeServicesServer) ListServices(context.Context, *pb.ListServicesRequest) (*pb.ListServicesResponse, error) {
func (*fakeServicesServer) ListServices(context.Context, *pb.ListServicesRequest) (*pb.ListServicesResponse, error) {
resp := pb.ListServicesResponse{}
if err := faker.FakeObject(&resp); err != nil {
return nil, fmt.Errorf("failed to fake data: %w", err)
Expand All @@ -36,7 +36,7 @@ type fakeVersionsServer struct {
pb.UnimplementedVersionsServer
}

func (f *fakeVersionsServer) ListVersions(context.Context, *pb.ListVersionsRequest) (*pb.ListVersionsResponse, error) {
func (*fakeVersionsServer) ListVersions(context.Context, *pb.ListVersionsRequest) (*pb.ListVersionsResponse, error) {
resp := pb.ListVersionsResponse{}
if err := faker.FakeObject(&resp); err != nil {
return nil, fmt.Errorf("failed to fake data: %w", err)
Expand All @@ -49,7 +49,7 @@ type fakeInstancesServer struct {
pb.UnimplementedInstancesServer
}

func (f *fakeInstancesServer) ListInstances(context.Context, *pb.ListInstancesRequest) (*pb.ListInstancesResponse, error) {
func (*fakeInstancesServer) ListInstances(context.Context, *pb.ListInstancesRequest) (*pb.ListInstancesResponse, error) {
resp := pb.ListInstancesResponse{}
if err := faker.FakeObject(&resp); err != nil {
return nil, fmt.Errorf("failed to fake data: %w", err)
Expand Down