Skip to content

feat(aws): Support Custom endpoints #5942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 8 commits into from
Dec 23, 2022
Merged

feat(aws): Support Custom endpoints #5942

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
381499e
Update client.go
bbernays Dec 23, 2022
e98d6a4
Update spec.go
bbernays Dec 23, 2022
d853d75
Merge remote-tracking branch 'upstream/main' into aws-custom-endpoint
bbernays Dec 23, 2022
bef0d69
Update configuration.md
bbernays Dec 23, 2022
2b28da5
Update spec.go
bbernays Dec 23, 2022
e586f1f
Create Configuring CloudQuery with LocalStack.md
bbernays Dec 23, 2022
40fb072
Update Configuring CloudQuery with LocalStack.md
bbernays Dec 23, 2022
a5d36b2
Delete Configuring CloudQuery with LocalStack.md
bbernays Dec 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update spec.go
  • Loading branch information
@bbernays
bbernays committed Dec 23, 2022
commit e98d6a4e25b6fac5f4d044d540553346fcedb21d
33 changes: 27 additions & 6 deletions plugins/source/aws/client/spec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package client

import "fmt"

type Account struct {
ID string `json:"id"`
AccountName string `json:"account_name,omitempty"`
Expand All @@ -23,10 +25,29 @@ type AwsOrg struct {
}

type Spec struct {
Regions []string `json:"regions,omitempty"`
Accounts []Account `json:"accounts"`
Organization *AwsOrg `json:"org"`
AWSDebug bool `json:"aws_debug,omitempty"`
MaxRetries *int `json:"max_retries,omitempty"`
MaxBackoff *int `json:"max_backoff,omitempty"`
Regions []string `json:"regions,omitempty"`
Accounts []Account `json:"accounts"`
Organization *AwsOrg `json:"org"`
AWSDebug bool `json:"aws_debug,omitempty"`
MaxRetries *int `json:"max_retries,omitempty"`
MaxBackoff *int `json:"max_backoff,omitempty"`
EndpointURL string `json:"custom_endpoint_url,omitempty"`
HostnameImmutable *bool `json:"custom_endpoint_hostname_immutable,omitempty"`
PartitionID string `json:"custom_endpoint_partition_id,omitempty"`
SigningRegion string `json:"custom_endpoint_signing_region,omitempty"`
}

func (s *Spec) Validate() error {
if s.EndpointURL != "" {
if s.PartitionID == "" {
return fmt.Errorf("custom_endpoint_partition_id is required when custom_endpoint_url is set")
}
if s.SigningRegion == "" {
return fmt.Errorf("custom_endpoint_signing_region is required when custom_endpoint_url is set")
}
if s.HostnameImmutable == nil {
return fmt.Errorf("custom_endpoint_hostname_immutable is required when custom_endpoint_url is set")
}
}
return nil
}