Skip to content

feat: Add instance_view to azure_compute_virtual_machines table #5941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 11 commits into from
Dec 25, 2022
Merged

feat: Add instance_view to azure_compute_virtual_machines table #5941

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
56604ae
chore(main): Release plugins-destination-mongodb v1.0.0
cq-bot Dec 23, 2022
ae3a16d
Merge branch 'main' into release-please--branches--main--components--…
yevgenypats Dec 23, 2022
7639dcc
fix mongodb website
yevgenypats Dec 23, 2022
19c72e1
feat(azure): Add virtual_machine_instance_views
yevgenypats Dec 23, 2022
47e2f98
Merge branch 'main' into feat/azure_instance_views
yevgenypats Dec 23, 2022
7750f05
fmt
yevgenypats Dec 23, 2022
8190815
turn instance_view into column
yevgenypats Dec 24, 2022
033b6d9
update docs
yevgenypats Dec 24, 2022
fe4531c
Update plugins/source/azure/codegen2/main.go
yevgenypats Dec 25, 2022
ca8429b
Update plugins/source/azure/codegen2/recipes/compute_e.go
yevgenypats Dec 25, 2022
3784cf9
Merge branch 'main' into feat/azure_instance_views
kodiakhq[bot] Dec 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update plugins/source/azure/codegen2/recipes/compute_e.go 
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
  • Loading branch information
@yevgenypats @erezrokah
yevgenypats and erezrokah authored Dec 25, 2022
commit ca8429b8e5a8da9fd5d140a2bcc5a410277345c5
22 changes: 0 additions & 22 deletions plugins/source/azure/codegen2/recipes/compute_e.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,28 +45,6 @@ func init() {
Resolver: `getInstanceView`,
},
},
// ExtraColumns: DefaultExtraColumns,
// Relations: []*Table{
// {
// Name: "virtual_machine_instance_views",
// Service: "armcompute",
// Struct: &armcompute.VirtualMachineInstanceView{},
// // ResponseStruct is just a stub for codegen not to fail
// ResponseStruct: &armcompute.VirtualMachinesClientInstanceViewResponse{},
// Client: &armcompute.VirtualMachinesClient{},
// ListFunc: (&armcompute.VirtualMachinesClient{}).InstanceView,
// NewFunc: armcompute.NewVirtualMachinesClient,
// URL: "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachines/{vmName}/instanceView",
// SkipFetch: true,
// ExtraColumns: []codegen.ColumnDefinition{
// {
// Name: "id",
// Type: schema.TypeString,
// Resolver: `schema.PathResolver("ComputerName")`,
// },
// },
// },
// },
},
}
Tables = append(Tables, tables...)
Expand Down