Skip to content

feat: Drift: Improvements#563

Merged
disq merged 9 commits into
cloudquery:mainfrom
disq:feat/drift-improvements
Apr 6, 2022
Merged

feat: Drift: Improvements#563
disq merged 9 commits into
cloudquery:mainfrom
disq:feat/drift-improvements

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Mar 30, 2022

  • Turns out the "combination feature" was kind of doable with the path statement but I still wanted to leave it in for now.
  • Added @if to GJSON value|@if:this,that (if value is this it will be replaced with that. if not, it will be left as-is)
  • Added @split to GJSON to split a string into an array: value1,value2|@split:, => [ value1, value2 ]
  • Added ability to run GJSON filters in the cloud provider attributes (in the attribute map) and updated drift protocol to v2
  • Added ability to define a single cloud resource multiple times (explicitly, using a 'hash' syntax, so that it doesn't get confused/lost in the map accesses) to be able to cover a blanket resource (think iam.accounts or ec2.regional_config) using multiple TF resources.
  • Removed -tf-mode cli param (which was pointless)

@disq disq requested review from a team and yevgenypats and removed request for a team March 30, 2022 20:06
@github-actions github-actions Bot added the feat label Mar 30, 2022
@disq disq requested a review from roneli March 30, 2022 20:08
@github-actions github-actions Bot added feat and removed feat labels Mar 30, 2022
@disq disq force-pushed the feat/drift-improvements branch from 71a8989 to 3428e43 Compare April 1, 2022 12:29
@github-actions github-actions Bot added feat and removed feat labels Apr 1, 2022
@github-actions github-actions Bot added feat and removed feat labels Apr 5, 2022
Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, had some comments and suggestions around new added function etc'

Comment thread pkg/module/drift/combination.go
Comment thread pkg/module/drift/config.go Outdated
Comment thread pkg/module/drift/model.go Outdated
Comment thread pkg/module/drift/model.go Outdated
Comment thread pkg/module/drift/model.go Outdated
@disq disq requested a review from roneli April 6, 2022 10:53
Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had one nit.

Comment thread pkg/module/drift/terraform.go
@disq disq merged commit a7b9455 into cloudquery:main Apr 6, 2022
@disq disq deleted the feat/drift-improvements branch April 6, 2022 12:42
TinLe pushed a commit to TinLe/cloudquery that referenced this pull request Apr 7, 2022
* upstream/main:
  feat: Purge stale data (cloudquery#565)
  feat: Add '--disable-fetch-check' flag (cloudquery#567)
  chore: Sync form .github (cloudquery#569)
  feat: Drift: Improvements (cloudquery#563)
  fix: Added error when connection configuration is not set (cloudquery#476)
  feat: Check for slashes in policy (cloudquery#561)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants