Skip to content

fix: Panic when canceled #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roneli merged 2 commits into from
Jan 26, 2022
Merged

fix: Panic when canceled #443

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea9742b
fix: Panic when canceled
disq Jan 26, 2022
2eee4e9
CR
disq Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/ui/console/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ func (c Client) Fetch(ctx context.Context, failOnError bool) error {
if st, ok := status.FromError(err); !ok || st.Code() != gcodes.Canceled {
return err
}

}

if ui.IsTerminal() && fetchProgress != nil {
Expand All @@ -138,6 +137,11 @@ func (c Client) Fetch(ctx context.Context, failOnError bool) error {
printFetchResponse(response)
}

if response == nil {
ui.ColorizedOutput(ui.ColorProgress, "Provider fetch canceled.\n\n")
return nil
}

ui.ColorizedOutput(ui.ColorProgress, "Provider fetch complete.\n\n")
for _, summary := range response.ProviderFetchSummary {
status := emojiStatus[ui.StatusOK]
Expand Down