Fix nil ptr error#2487
Closed
bbernays wants to merge 2 commits into
Closed
Conversation
bbernays
commented
Oct 6, 2022
Comment on lines
+23
to
+34
| subTemp := types.Subscription{} | ||
| err = faker.FakeData(&subTemp) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| emptySub := types.Subscription{ | ||
| SubscriptionArn: aws.String("PendingConfirmation"), | ||
| Owner: subTemp.Owner, | ||
| Protocol: subTemp.Protocol, | ||
| TopicArn: subTemp.TopicArn, | ||
| Endpoint: subTemp.Endpoint, | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
@amanenk - I would also add this test case to your PR
yevgenypats
reviewed
Oct 6, 2022
| @@ -138,7 +138,9 @@ func MarshaledJsonResolver(path string) schema.ColumnResolver { | |||
| return func(_ context.Context, meta schema.ClientMeta, r *schema.Resource, c schema.Column) error { | |||
Contributor
There was a problem hiding this comment.
Do we have a test for this function? if not I think we should add it and add the test case that causes this.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be closed once @amanenk PR is merged