fix: Add back missing plugin logs#2389
Merged
Merged
Conversation
disq
approved these changes
Oct 4, 2022
yevgenypats
approved these changes
Oct 4, 2022
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
looks good, one nit around logging.
|
|
||
| func sync(cmd *cobra.Command, args []string) error { | ||
| ctx := cmd.Context() | ||
| log.Info().Msg("Start sync") |
Contributor
There was a problem hiding this comment.
I think we should move this to syncConnection and add source and destinations=[] to that as otherwise it's missing information and sync_tmie
disq
reviewed
Oct 4, 2022
disq
reviewed
Oct 4, 2022
kodiakhq Bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
🤖 I have created a release *beep* *boop* --- ## [1.0.3](cli-v1.0.2...cli-v1.0.3) (2022-10-04) ### Bug Fixes * Add back missing plugin logs ([#2389](#2389)) ([f3335a8](f3335a8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where plugin logs were not being streamed to
cloudquery.log. It also adds a test for this to catch future regressions.