Repository navigation
fix: Run delete-stale on every overwrite-delete-stale destination - #23548
Merged
Merged
Conversation
 [Medium impact] The PR appears safe to merge.
|
erezrokah
approved these changes
Oct 15, 2026
erezrokah
left a comment
Member
There was a problem hiding this comment.
LGTM. Traced the delete back to #18833. It looks like a leftover from an in-place version of UpdateTableNames, and nothing after the delete-stale loop reads tablesForDeleteStale, so removing it is safe.
Non-blocking, can be follow-ups:
- With
--no-migrate,LearnTableNameChangenever runs (continuebefore it), so delete-stale and DeleteRecord still use the untransformed names when a destination has achange_table_namestransformer. UpdateTableNamescould callUpdateTableNameinstead of repeating the lookup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateTableNamesno longer deletes entries from its input map, so everyoverwrite-delete-staledestination of a source runs delete-stale, not only the first.