feat: Report source plugin versions to the injected platform destination#22988
Draft
disq wants to merge 2 commits into
Draft
feat: Report source plugin versions to the injected platform destination#22988disq wants to merge 2 commits into
disq wants to merge 2 commits into
Conversation
Inject a `source_versions` list ({name, path, version}) for the sync's sources
into the auto-injected platform destination spec, so the platform can reject
sources whose version the asset view can't process before any upload.
Use a local sourceVersion struct instead of []map[string]string (self-documenting, guards against key typos). Add a two-source case asserting order and that none are dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #22945 (base:
claude/platform-dest-cli-session-mint).When auto-injecting the platform destination, also inject a
source_versionslist ([]{name, path, version}) for the sync's sources into the destination spec.The destination forwards it as the now-required
sourcesonCreateExternalSync(cloudquery-private#12848), so the platform can reject — at sync open, before any upload — sources whose version the asset view can't process. Supported window is same major and ≤ the pinned corpus version[<major>.0.0 .. pinned]; the gate is on by default with a per-tenant opt-out (platform cloudquery/platform#2995).The CLI only reports; the platform owns the decision. Each
*specs.Sourcecontributes itsname/path(cloudquery/<name>) /version.Tests:
inject_test.goasserts the injectedsource_versions.