feat: Support Databricks Lakebase as a destination#22944
Open
bbernays wants to merge 14 commits into
Open
Conversation
Copilot stopped reviewing on behalf of
bbernays due to an error
June 11, 2026 14:38
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds Databricks Lakebase connectivity to the PostgreSQL destination by introducing a lakebase spec block that mints short-lived OAuth DB credentials per connection via the Databricks SDK.
Changes:
- Add
lakebasespec/schema/docs and validation for requiredlakebase.endpoint. - Introduce Lakebase connection wiring (
BeforeConnecttoken minting + max connection lifetime cap) and apply it in both client creation and connection testing. - Update Go module dependencies, checksums, tests, and license documentation for newly introduced dependencies.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/destination/postgresql/go.mod | Adds Databricks SDK and related indirect deps required for Lakebase auth. |
| plugins/destination/postgresql/go.sum | Records checksums for the new direct/indirect dependencies. |
| plugins/destination/postgresql/docs/overview.md | Documents the new lakebase block and provides an example config. |
| plugins/destination/postgresql/docs/_licenses.md | Updates third-party license list for newly pulled dependencies. |
| plugins/destination/postgresql/client/spec/spec.go | Adds LakebaseSpec, HasLakebaseConfig, and validates lakebase.endpoint. |
| plugins/destination/postgresql/client/spec/schema.json | Extends JSON schema with LakebaseSpec and lakebase field. |
| plugins/destination/postgresql/client/spec/spec_test.go | Adds schema/validation test cases for lakebase configs. |
| plugins/destination/postgresql/client/spec/lakebase_test.go | Adds unit tests for Lakebase spec validation and presence detection. |
| plugins/destination/postgresql/client/lakebase.go | Implements Lakebase auth wiring and connection lifetime capping. |
| plugins/destination/postgresql/client/lakebase_test.go | Tests lifetime-capping and ensures BeforeConnect is set. |
| plugins/destination/postgresql/client/client.go | Applies Lakebase configuration when initializing the pgx pool. |
| plugins/destination/postgresql/client/connection_tester.go | Applies Lakebase configuration during connection tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary