Skip to content

feat: Better summary of schema changes #21166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Jul 29, 2025
Merged

feat: Better summary of schema changes #21166

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d78821a
feat: Better summary of schema changes
erezrokah Jul 29, 2025
3f91881
Merge branch 'main' into feat/better_changes_message_clickhouse
erezrokah Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions plugins/destination/clickhouse/client/migrate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,13 @@ func (c *Client) MigrateTables(ctx context.Context, messages message.WriteMigrat
return allTablesChanges[table].forcedMigrationNeeded && !tablesWeCanForceMigrate[table]
})
if len(nonAutoMigratableTables) > 0 {
changes := lo.Map(nonAutoMigratableTables, func(table string, _ int) []schema.TableColumnChange {
return allTablesChanges[table].changes
})
return fmt.Errorf("tables %s with changes %v require migration. Migrate manually or consider using 'migrate_mode: forced'", strings.Join(nonAutoMigratableTables, ","), changes)
changes := lo.FromEntries(lo.Map(nonAutoMigratableTables, func(table string, _ int) lo.Entry[string, []schema.TableColumnChange] {
return lo.Entry[string, []schema.TableColumnChange]{
Key: table,
Value: allTablesChanges[table].changes,
}
}))
return fmt.Errorf("\nCan't migrate tables automatically, migrate manually or consider using 'migrate_mode: forced'. Non auto migratable tables changes:\n\n%s", schema.GetChangesSummary(changes))
}

const maxConcurrentMigrate = 10
Expand Down