Skip to content

feat: Pass invocation ID to scheduler #18510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Jul 10, 2024
Merged

feat: Pass invocation ID to scheduler #18510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70049b1
feat: Pass invocation ID to scheduler
erezrokah Jul 9, 2024
a211c79
Merge branch 'main' into feat/pass_invocation_id
kodiakhq[bot] Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions plugins/source/hackernews/resources/plugin/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"encoding/json"
"fmt"

"github.com/cloudquery/cloudquery/plugins/source/hackernews/client"
"github.com/cloudquery/cloudquery/plugins/source/hackernews/resources/services/items"
"github.com/cloudquery/plugin-sdk/v4/message"
Expand Down Expand Up @@ -101,6 +102,7 @@ func Configure(_ context.Context, logger zerolog.Logger, specBytes []byte, opts
logger: logger,
scheduler: scheduler.NewScheduler(
scheduler.WithLogger(logger),
scheduler.WithInvocationID(opts.InvocationID),
),
tables: getTables(),
}, nil
Expand Down
2 changes: 1 addition & 1 deletion plugins/source/k8s/resources/plugin/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ func newClient(ctx context.Context, logger zerolog.Logger, specBytes []byte, opt
return nil, err
}
c.syncClient = syncClient.(*client.Client)
c.scheduler = scheduler.NewScheduler(scheduler.WithLogger(logger), scheduler.WithConcurrency(s.Concurrency))
c.scheduler = scheduler.NewScheduler(scheduler.WithLogger(logger), scheduler.WithConcurrency(s.Concurrency), scheduler.WithInvocationID(options.InvocationID))
Copy link
Copy Markdown
Contributor

@blesniewski blesniewski Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
c.scheduler = scheduler.NewScheduler(scheduler.WithLogger(logger), scheduler.WithConcurrency(s.Concurrency), scheduler.WithInvocationID(options.InvocationID))
c.scheduler = scheduler.NewScheduler(
scheduler.WithLogger(logger),
scheduler.WithConcurrency(s.Concurrency),
scheduler.WithInvocationID(options.InvocationID),
)

return c, nil
}

Expand Down
1 change: 1 addition & 0 deletions plugins/source/test/resources/plugin/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ func Configure(_ context.Context, logger zerolog.Logger, spec []byte, opts plugi
config: *config,
scheduler: scheduler.NewScheduler(
scheduler.WithLogger(logger),
scheduler.WithInvocationID(opts.InvocationID),
),
tables: getTables(*config),
}, nil
Expand Down
1 change: 1 addition & 0 deletions plugins/source/xkcd/resources/plugin/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ func Configure(_ context.Context, logger zerolog.Logger, specBytes []byte, opts
scheduler: scheduler.NewScheduler(
scheduler.WithLogger(logger),
scheduler.WithConcurrency(config.Concurrency),
scheduler.WithInvocationID(opts.InvocationID),
),
services: xkcdClient,
tables: getTables(),
Expand Down