Skip to content

fix: Fix pagination logic for responses on Typeform plugin. #18479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Jul 8, 2024
Merged

fix: Fix pagination logic for responses on Typeform plugin. #18479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d5b6a6
fix: Fix pagination logic for responses on Typeform plugin.
marianogappa Jul 5, 2024
72004cd
Merge branch 'main' into mariano/fix-typeform-responses-bug
marianogappa Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/source/typeform/plugin/typeform/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ def list_form_responses(self, form_id, page=1):
yield form

if resp["page_count"] > page:
yield from self.list_form_responses(page + 1)
yield from self.list_form_responses(form_id, page + 1)
39 changes: 39 additions & 0 deletions plugins/source/typeform/tests/typeform/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ def do_GET(self):
if parts[0] == "/forms":
query = parse_qs(parts[1])
self._handle_forms(q=query)
elif parts[0] == "/forms/form1/responses":
query = parse_qs(parts[1])
self._handle_forms_responses(q=query)
else:
self.send_response(requests.codes.not_found)
self.end_headers()
Expand Down Expand Up @@ -48,6 +51,32 @@ def _handle_forms(self, q):
}
self.wfile.write(json.dumps(resp).encode("utf-8"))

def _handle_forms_responses(self, q):
self.send_response(requests.codes.ok)
self.end_headers()
if q["page"] == ["1"]:
resp = {
"items": [
{
"answers": [],
"submitted_at": "2017-09-14T22:38:22Z",
},
],
"page_count": 2,
}
self.wfile.write(json.dumps(resp).encode("utf-8"))
else:
resp = {
"items": [
{
"answers": [],
"submitted_at": "2017-09-14T22:33:56Z",
},
],
"page_count": 2,
}
self.wfile.write(json.dumps(resp).encode("utf-8"))


def get_free_port():
s = socket.socket(socket.AF_INET, type=socket.SOCK_STREAM)
Expand Down Expand Up @@ -81,3 +110,13 @@ def test_list_forms(self):
assert len(forms) == 2
assert forms[0]["id"] == "form1"
assert forms[1]["id"] == "form2"

def test_list_forms_responses(self):
client = TypeformClient(
base_url="http://localhost:{}".format(self.mock_server_port),
access_token="fake",
)
forms = list(client.list_form_responses("form1"))
assert len(forms) == 2
assert forms[0]["submitted_at"] == "2017-09-14T22:38:22Z"
assert forms[1]["submitted_at"] == "2017-09-14T22:33:56Z"