fix: Skip relations of incremental tables from delete stale#18239
Merged
kodiakhq[bot] merged 3 commits intoJun 19, 2024
Merged
Conversation
5 tasks
kodiakhq Bot
pushed a commit
to cloudquery/plugin-sdk
that referenced
this pull request
Jun 19, 2024
#### Summary Needed for cloudquery/cloudquery#18239 ---
candiduslynx
approved these changes
Jun 19, 2024
erezrokah
commented
Jun 19, 2024
kodiakhq Bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
🤖 I have created a release *beep* *boop* --- ## [5.22.1](cli-v5.22.0...cli-v5.22.1) (2024-06-19) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.45.4 ([#18299](#18299)) ([200480a](200480a)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.45.5 ([#18327](#18327)) ([42d5850](42d5850)) * Skip relations of incremental tables from delete stale ([#18239](#18239)) ([4c65730](4c65730)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes https://github.com/cloudquery/cloudquery-issues/issues/1844 (internal issue).
Relations of incremental tables gets cleared due to delete stale, we should exclude them I think.
The fix works since we always sync parents from before children, so parents get excluded first.
Still needs to test this.Blocked by cloudquery/plugin-sdk#1742 (I mean the code works, but the bug won't be fixed until source plugins upgrade to latest SDK)