feat: Add JSON Schema to Okta source plugin#16493
Merged
Merged
Conversation
candiduslynx
suggested changes
Feb 2, 2024
candiduslynx
reviewed
Feb 3, 2024
Contributor
candiduslynx
left a comment
There was a problem hiding this comment.
I still think it's a good time to just drop the env var in a separate PR, then rebase & reintroduce token as a required param
| }, | ||
| { | ||
| Name: "spec with token and domain and zero rate limit", | ||
| Spec: `{"token": "tok", "domain": "https://domain.okta.com", "rate_limit": {"max_backoff": 0}}`, |
Contributor
There was a problem hiding this comment.
rl tests could be extracted into a separate func, see https://github.com/cloudquery/cloudquery/blob/main/plugins/source/aws/client/spec/organization_test.go
| }, | ||
| { | ||
| Name: "spec with token and domain and invalid rate limit", | ||
| Spec: `{"token": "tok", "domain": "https://domain.okta.com", "rate_limit": {"max_backoff": true}}`, |
Contributor
There was a problem hiding this comment.
remove token from tests (only leave for the tests that are actually testing token)
Contributor
There was a problem hiding this comment.
Or merge #16498 & reintroduce requirement for token (better IMO)
Contributor
candiduslynx
approved these changes
Feb 5, 2024
kodiakhq Bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
🤖 I have created a release *beep* *boop* --- ## [4.0.0](plugins-source-okta-v3.2.18...plugins-source-okta-v4.0.0) (2024-02-06) ### ⚠ BREAKING CHANGES * Remove support for deprecated `OKTA_API_TOKEN` environment variable ([#16498](#16498)) ### Features * Add JSON Schema to Okta source plugin ([#16493](#16493)) ([75ce0ab](75ce0ab)) ### Bug Fixes * **deps:** Update golang.org/x/exp digest to 1b97071 ([#16419](#16419)) ([6d77cd1](6d77cd1)) * **deps:** Update google.golang.org/genproto/googleapis/api digest to 1f4bbc5 ([#16421](#16421)) ([9489931](9489931)) * **deps:** Update google.golang.org/genproto/googleapis/rpc digest to 1f4bbc5 ([#16422](#16422)) ([74e98fc](74e98fc)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.27.0 ([#16237](#16237)) ([3fcdab0](3fcdab0)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.27.1 ([#16296](#16296)) ([ab4a0da](ab4a0da)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.27.2 ([#16342](#16342)) ([f3eb857](f3eb857)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.28.0 ([#16362](#16362)) ([9166b6b](9166b6b)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.29.0 ([#16395](#16395)) ([fb1102e](fb1102e)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.29.1 ([#16430](#16430)) ([738e89f](738e89f)) * Remove support for deprecated `OKTA_API_TOKEN` environment variable ([#16498](#16498)) ([25303df](25303df)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16453