Skip to content

feat: Add JSON schema to mssql destination plugin#16438

Merged
kodiakhq[bot] merged 3 commits into
mainfrom
feat/jsonschema/mssql
Feb 1, 2024
Merged

feat: Add JSON schema to mssql destination plugin#16438
kodiakhq[bot] merged 3 commits into
mainfrom
feat/jsonschema/mssql

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Feb 1, 2024

Closes #16434

@disq disq requested a review from a team February 1, 2024 15:08
@disq disq requested a review from candiduslynx February 1, 2024 15:08
@disq disq added the automerge Automatically merge once required checks pass label Feb 1, 2024
@cq-bot cq-bot added area/plugin/destination/mssql area/ci and removed automerge Automatically merge once required checks pass labels Feb 1, 2024
Copy link
Copy Markdown
Contributor

@candiduslynx candiduslynx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread plugins/destination/mssql/client/spec.go
}

func (AuthMode) JSONSchemaExtend(sc *jsonschema.Schema) {
sc.Type = "string"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not actually required (generator probably handles this just fine)

@disq disq added the automerge Automatically merge once required checks pass label Feb 1, 2024
@kodiakhq kodiakhq Bot merged commit cd09032 into main Feb 1, 2024
@kodiakhq kodiakhq Bot deleted the feat/jsonschema/mssql branch February 1, 2024 15:31
kodiakhq Bot pushed a commit that referenced this pull request Feb 14, 2024
🤖 I have created a release *beep* *boop*
---


## [4.4.0](plugins-destination-mssql-v4.3.22...plugins-destination-mssql-v4.4.0) (2024-02-14)


### Features

* Add JSON schema to mssql destination plugin ([#16438](#16438)) ([cd09032](cd09032))


### Bug Fixes

* **deps:** Update Azure modules ([#16563](#16563)) ([7b1262a](7b1262a))
* **deps:** Update github.com/cloudquery/jsonschema digest to d771afd ([#16483](#16483)) ([dcaa994](dcaa994))
* **deps:** Update golang.org/x/exp digest to 1b97071 ([#16419](#16419)) ([6d77cd1](6d77cd1))
* **deps:** Update google.golang.org/genproto/googleapis/api digest to 1f4bbc5 ([#16421](#16421)) ([9489931](9489931))
* **deps:** Update google.golang.org/genproto/googleapis/rpc digest to 1f4bbc5 ([#16422](#16422)) ([74e98fc](74e98fc))
* **deps:** Update module github.com/Azure/azure-sdk-for-go/sdk/azidentity to v1.5.1 ([#16325](#16325)) ([b9c6a65](b9c6a65))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.27.0 ([#16237](#16237)) ([3fcdab0](3fcdab0))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.27.1 ([#16296](#16296)) ([ab4a0da](ab4a0da))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.27.2 ([#16342](#16342)) ([f3eb857](f3eb857))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.28.0 ([#16362](#16362)) ([9166b6b](9166b6b))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.29.0 ([#16395](#16395)) ([fb1102e](fb1102e))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.29.1 ([#16430](#16430)) ([738e89f](738e89f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci area/plugin/destination/mssql automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add JSON schema to plugins/destination/mssql

3 participants