Skip to content

feat: Adding JSON schema support to firestore plugin#16380

Merged
kodiakhq[bot] merged 11 commits into
mainfrom
feat/adding-jsonschema-firestore
Jan 31, 2024
Merged

feat: Adding JSON schema support to firestore plugin#16380
kodiakhq[bot] merged 11 commits into
mainfrom
feat/adding-jsonschema-firestore

Conversation

@mnorbury
Copy link
Copy Markdown
Contributor

fixes: #16359

@mnorbury mnorbury requested review from a team and bbernays and removed request for a team January 31, 2024 11:10
@mnorbury mnorbury force-pushed the feat/adding-jsonschema-firestore branch from d4ac5a9 to 0cdf8a1 Compare January 31, 2024 11:11
@mnorbury mnorbury requested review from candiduslynx and removed request for bbernays January 31, 2024 11:13
@mnorbury mnorbury added the automerge Automatically merge once required checks pass label Jan 31, 2024
Copy link
Copy Markdown
Contributor

@candiduslynx candiduslynx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to edit the descriptions/comments, but otherwise good

Comment thread plugins/source/firestore/client/spec.go Outdated
Comment thread plugins/source/firestore/client/spec.go Outdated
Comment thread plugins/source/firestore/client/spec.go Outdated
Comment thread plugins/source/firestore/client/spec.go Outdated
Comment thread plugins/source/firestore/client/spec.go Outdated
Comment thread plugins/source/firestore/client/spec.go Outdated
mnorbury and others added 8 commits January 31, 2024 11:24
Co-authored-by: Alex Shcherbakov <candiduslynx@users.noreply.github.com>
Co-authored-by: Alex Shcherbakov <candiduslynx@users.noreply.github.com>
Co-authored-by: Alex Shcherbakov <candiduslynx@users.noreply.github.com>
Co-authored-by: Alex Shcherbakov <candiduslynx@users.noreply.github.com>
Co-authored-by: Alex Shcherbakov <candiduslynx@users.noreply.github.com>
Co-authored-by: Alex Shcherbakov <candiduslynx@users.noreply.github.com>
@cq-bot cq-bot added the area/ci label Jan 31, 2024
@mnorbury mnorbury added automerge Automatically merge once required checks pass and removed automerge Automatically merge once required checks pass area/ci labels Jan 31, 2024
@mnorbury mnorbury requested a review from candiduslynx January 31, 2024 11:41
@mnorbury
Copy link
Copy Markdown
Contributor Author

I'd like to edit the descriptions/comments, but otherwise good

👍 Committed the doc changes - and added the workflow to make gen that I had missed.

Copy link
Copy Markdown
Contributor

@candiduslynx candiduslynx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unnecessary step from workflow, but otherwise good

Comment thread .github/workflows/source_firestore.yml Outdated
@cq-bot cq-bot added the area/ci label Jan 31, 2024
@mnorbury mnorbury requested a review from candiduslynx January 31, 2024 13:04
@kodiakhq kodiakhq Bot merged commit 16dab3a into main Jan 31, 2024
@kodiakhq kodiakhq Bot deleted the feat/adding-jsonschema-firestore branch January 31, 2024 13:43
kodiakhq Bot pushed a commit that referenced this pull request Jan 31, 2024
🤖 I have created a release *beep* *boop*
---


## [3.1.0](plugins-source-firestore-v3.0.20...plugins-source-firestore-v3.1.0) (2024-01-31)


### Features

* Adding JSON schema support to firestore plugin ([#16380](#16380)) ([16dab3a](16dab3a))


### Bug Fixes

* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.27.0 ([#16237](#16237)) ([3fcdab0](3fcdab0))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.27.1 ([#16296](#16296)) ([ab4a0da](ab4a0da))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.27.2 ([#16342](#16342)) ([f3eb857](f3eb857))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.28.0 ([#16362](#16362)) ([9166b6b](9166b6b))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci area/plugin/source/firestore automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add JSON schema to plugins/source/firestore

3 participants