feat: Support adding a spec json schema to plugin versions#16368
Merged
kodiakhq[bot] merged 2 commits intoJan 31, 2024
Conversation
f2eff7d to
4922631
Compare
| return nil | ||
| } | ||
|
|
||
| func GetSpecJsonScheme(distDir string) (*string, error) { |
Contributor
There was a problem hiding this comment.
Suggested change
| func GetSpecJsonScheme(distDir string) (*string, error) { | |
| func GetSpecJSONSchema(distDir string) (*string, error) { |
hermanschaaf
approved these changes
Jan 31, 2024
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
Small typo in the function name but otherwise LGTM
kodiakhq Bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
🤖 I have created a release *beep* *boop* --- ## [5.2.0](cli-v5.1.2...cli-v5.2.0) (2024-01-31) ### Features * Support adding a spec json schema to plugin versions ([#16368](#16368)) ([7eaf28f](7eaf28f)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.7.1 ([#16381](#16381)) ([2693478](2693478)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.27.2 ([#16342](#16342)) ([f3eb857](f3eb857)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.28.0 ([#16362](#16362)) ([9166b6b](9166b6b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Goes with cloudquery/cloudquery-api-go#114