feat: Add JSON schema support to Datadog source plugin#16358
Merged
Conversation
|
|
||
| import _ "embed" | ||
|
|
||
| type Spec struct { |
Contributor
There was a problem hiding this comment.
It would be great to add the descriptions from https://hub.cloudquery.io/plugins/source/cloudquery/datadog/v4.2.8/docs?search=datadog#configuration-datadog-spec as comments here, so it will be propagated to the JSONSchema as well
hermanschaaf
approved these changes
Jan 30, 2024
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
Nit about the descriptions, otherwise LGTM 👍
5f8f536 to
5532fb0
Compare
9f75bdf to
8a92e76
Compare
This was referenced Jan 30, 2024
kodiakhq Bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
🤖 I have created a release *beep* *boop* --- ## [6.1.0](plugins-source-cloudflare-v6.0.3...plugins-source-cloudflare-v6.1.0) (2024-01-31) ### Features * Add JSON schema support to Datadog source plugin ([#16358](#16358)) ([4af95e3](4af95e3)) * Adding JSON Schema support to Cloudflare ([#16357](#16357)) ([806a968](806a968)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.27.0 ([#16237](#16237)) ([3fcdab0](3fcdab0)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.27.1 ([#16296](#16296)) ([ab4a0da](ab4a0da)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.27.2 ([#16342](#16342)) ([f3eb857](f3eb857)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.28.0 ([#16362](#16362)) ([9166b6b](9166b6b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq Bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
🤖 I have created a release *beep* *boop* --- ## [4.3.0](plugins-source-datadog-v4.2.8...plugins-source-datadog-v4.3.0) (2024-01-31) ### Features * Add JSON schema support to Datadog source plugin ([#16358](#16358)) ([4af95e3](4af95e3)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.27.0 ([#16237](#16237)) ([3fcdab0](3fcdab0)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.27.1 ([#16296](#16296)) ([ab4a0da](ab4a0da)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.27.2 ([#16342](#16342)) ([f3eb857](f3eb857)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.28.0 ([#16362](#16362)) ([9166b6b](9166b6b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #16336