fix: Build arm64 docker images with arm64 platform#16231
Merged
Conversation
erezrokah
reviewed
Jan 23, 2024
Member
erezrokah
left a comment
There was a problem hiding this comment.
I think you'll need to add:
-
name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3Before
Member
Author
|
@erezrokah Added, I thought it already had buildx, but obviously didn't |
erezrokah
reviewed
Jan 23, 2024
Member
|
Also probably you could test this via |
Member
Author
|
@erezrokah added (not sure correctly?) in goreleaser seems to work (once I switched to docker default context) I'm not sure if I should also create manifests using |
erezrokah
reviewed
Jan 23, 2024
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Member
Author
|
@erezrokah Makes much more sense now thanks |
erezrokah
approved these changes
Jan 24, 2024
erezrokah
approved these changes
Jan 24, 2024
erezrokah
added a commit
that referenced
this pull request
Jan 24, 2024
<!-- 🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 --> #### Summary Follow up to #16231 <!-- Use the following steps to ensure your PR is ready to be reviewed - [ ] Read the [contribution guidelines](https://github.com/cloudquery/cloudquery/blob/main/CONTRIBUTING.md) 🧑🎓 - [ ] Run `make lint` to ensure the proposed changes follow the coding style 🚨 (install golangci-lint [here](https://golangci-lint.run/usage/install/#local-installation)) - [ ] Run `make test` to ensure the proposed changes pass the tests 🧪 - [ ] If changing a source plugin run `make gen` to ensure docs are up to date 📝 - [ ] Ensure the status checks below are successful ✅ --->
kodiakhq Bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
🤖 I have created a release *beep* *boop* --- ## [5.1.1](cli-v5.1.0...cli-v5.1.1) (2024-01-24) ### Bug Fixes * Build arm64 docker images with arm64 platform ([#16231](#16231)) ([23dbf9c](23dbf9c)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.27.1 ([#16296](#16296)) ([ab4a0da](ab4a0da)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq Bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
Reverts the last commit from #16231
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could fix #16218
https://goreleaser.com/cookbooks/multi-platform-docker-images/#creating-multi-platform-docker-images-with-goreleaser also mentions qemu, but I'm not sure it's needed after checking https://github.com/docker/setup-qemu-action/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc