fix: Handle docker.cloudquery.io docker registry when checking if auth is needed#16159
Merged
Merged
Conversation
disq
reviewed
Jan 16, 2024
Co-authored-by: Kemal <223029+disq@users.noreply.github.com>
disq
approved these changes
Jan 16, 2024
kodiakhq Bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
🤖 I have created a release *beep* *boop* --- ## [5.0.1](cli-v5.0.0...cli-v5.0.1) (2024-01-16) ### Bug Fixes * **deps:** Update github.com/apache/arrow/go/v15 digest to 7e703aa ([#16134](#16134)) ([72d5eb3](72d5eb3)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.25.2 ([#16130](#16130)) ([7ae6f41](7ae6f41)) * Handle `docker.cloudquery.io` docker registry when checking if auth is needed ([#16159](#16159)) ([8d06516](8d06516)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the CLI logic a bit to try and get auth token if someone references our own docker registry. We use this logic to recommend users to
cloudquery loginif they reference our registry