fix: Add X-Meta-User-Team-Name during docker push#16013
Merged
kodiakhq[bot] merged 1 commit intoJan 3, 2024
Merged
Conversation
disq
approved these changes
Jan 3, 2024
kodiakhq Bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
🤖 I have created a release *beep* *boop* --- ## [5.0.0](cli-v4.4.0...cli-v5.0.0) (2024-01-12) ### ⚠ BREAKING CHANGES * Remove deprecated top level spec options (#15999). The following deprecated spec options were removed: * source plugin top level spec: * `concurrency` * `table_concurrency` * `resource_concurrency` * `backend` * `backend_spec` * destination plugin top level spec: * `batch_size` * `batch_size_bytes` **For most users this shouldn't be a breaking change**. We've deprecated these options a while ago and some were moved to the plugin level spec. If you were using the deprecated options on a CLI version lower than `v5.0.0` you should have gotten a warning about it. ### Features * Add JSON schema for CLI specs ([#15998](#15998)) ([da02049](da02049)) * Remove deprecated spec options (#15999) ([9e25f4a](9e25f4a)) * Upload images from markdown files to CDN when publishing ([#16033](#16033)) ([cf7cdb1](cf7cdb1)) ### Bug Fixes * Add `X-Meta-User-Team-Name` during docker push ([#16013](#16013)) ([129b7c2](129b7c2)) * Add missing `X-Meta-User-Team-Name` header and manifest types option ([#16113](#16113)) ([9d8899e](9d8899e)) * **deps:** Update github.com/apache/arrow/go/v15 digest to 6d44906 ([#16115](#16115)) ([8b0ae62](8b0ae62)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.6.4 ([#16067](#16067)) ([2e7b7d6](2e7b7d6)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.16.2 ([#15948](#15948)) ([2def2ef](2def2ef)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.16.3 ([#16002](#16002)) ([e2d5605](e2d5605)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.16.4 ([#16126](#16126)) ([6a776ae](6a776ae)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.25.0 ([#15932](#15932)) ([2292b5a](2292b5a)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.25.1 ([#16069](#16069)) ([edda65c](edda65c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The requirement for this header was added recently in the backend to track downloads, so the backend needs to know the team that's downloading the plugin. It's less relevant for the push operation though, but still needed. It's ok to use the team from the manifest - it just has to be any team the user is a part of. During push we already verify the token used to push has access to the team.