feat: Support publishing to a private docker registry#15698
Merged
Conversation
erezrokah
commented
Dec 14, 2023
| return nil | ||
| } | ||
|
|
||
| func PublishToDockerRegistry(ctx context.Context, token, distDir string, pkgJSON PackageJSONV1) error { |
Member
Author
There was a problem hiding this comment.
This is the bulk of the change
erezrokah
commented
Dec 14, 2023
| ) | ||
| } | ||
|
|
||
| func (pr *dockerProgressReader) Read(_ []byte) (n int, err error) { |
Member
Author
There was a problem hiding this comment.
d6b3842 to
78cde21
Compare
erezrokah
commented
Dec 15, 2023
| return errors.New("invalid plugin name. Must be in format <team_name>/<plugin_name>") | ||
| } | ||
| teamName, pluginName = parts[0], parts[1] | ||
| pkgJSON.Team, pkgJSON.Name = teamName, pluginName |
Member
Author
There was a problem hiding this comment.
This is backwards compatibility code from when we had plugin publish <team>/<name> instead of inside package.json.
I cleaned up some of the arguments to UploadPluginBinary to pass only the package JSON so we need to set these here
Member
Author
|
7a5784c makes it so we merge all platforms into a single image: |
maaarcelino
reviewed
Dec 28, 2023
maaarcelino
reviewed
Dec 28, 2023
2f48e2e to
95c26f3
Compare
maaarcelino
approved these changes
Dec 29, 2023
kodiakhq Bot
pushed a commit
that referenced
this pull request
Jan 2, 2024
🤖 I have created a release *beep* *boop* --- ## [4.4.0](cli-v4.3.6...cli-v4.4.0) (2024-01-02) ### Features * Offline licensing support ([#15831](#15831)) ([7eab631](7eab631)) * Support publishing to a private docker registry ([#15698](#15698)) ([36e0351](36e0351)) ### Bug Fixes * **deps:** Update github.com/apache/arrow/go/v15 digest to 7c3480e ([#15904](#15904)) ([a3ec012](a3ec012)) * **deps:** Update github.com/gomarkdown/markdown digest to 1d6d208 ([#15907](#15907)) ([86d29a9](86d29a9)) * **deps:** Update golang.org/x/exp digest to 02704c9 ([#15909](#15909)) ([dfe32d2](dfe32d2)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.15.0 ([#15851](#15851)) ([f51f12d](f51f12d)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.16.0 ([#15856](#15856)) ([0d63c66](0d63c66)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.24.0 ([#15863](#15863)) ([47d7899](47d7899)) * **deps:** Update module github.com/prometheus/client_golang to v1.11.1 [SECURITY] ([#15855](#15855)) ([676805b](676805b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Example (images generated with cloudquery/plugin-sdk-javascript#106)
The images were generated by cloudquery/plugin-sdk-javascript#106 (replacing
registry.cloudquery.iowithghcr.io)TODO
docker manifest. The is done bydocker buildx --pushautomatically at the moment incloudquery/.github/workflows/release_plugin.yml
Line 94 in 67c10c3