fix: Remove stale code#13445
Merged
Merged
Conversation
yevgenypats
approved these changes
Aug 30, 2023
erezrokah
approved these changes
Aug 30, 2023
erezrokah
reviewed
Aug 30, 2023
| defaultBatchSize = 10000 | ||
| defaultBatchSizeBytes = 1000000 | ||
| defaultBatchTimeout = 10 * time.Second | ||
| defaultBatchSizeBytes = 100000000 |
Member
There was a problem hiding this comment.
We should release a new Postgres version with this
Member
There was a problem hiding this comment.
I made https://github.com/cloudquery/cloudquery/releases/tag/plugins-destination-postgresql-v6.0.1 a pre-release since it has the old batch settings and also doesn't have #13332
This was referenced Aug 30, 2023
kodiakhq Bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
🤖 I have created a release *beep* *boop* --- ## [3.0.6](plugins-source-pagerduty-v3.0.5...plugins-source-pagerduty-v3.0.6) (2023-08-30) ### Bug Fixes * **deps:** Update `github.com/cloudquery/arrow/go/v13` to `github.com/apache/arrow/go/v14` ([#13341](#13341)) ([feb8f87](feb8f87)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 5b83d4f ([#13203](#13203)) ([b0a4b8c](b0a4b8c)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.5.1 ([#13195](#13195)) ([a184c37](a184c37)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.5.2 ([#13262](#13262)) ([5c55aa3](5c55aa3)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.5.5 ([#13285](#13285)) ([e076abd](e076abd)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.5.6 ([#13345](#13345)) ([a995a05](a995a05)) * Remove stale code ([#13445](#13445)) ([cc30fb0](cc30fb0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq Bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
🤖 I have created a release *beep* *boop* --- ## [6.0.2](plugins-destination-postgresql-v6.0.1...plugins-destination-postgresql-v6.0.2) (2023-08-30) ### Bug Fixes * Drop include clause from list tables ([#13429](#13429)) ([9064d8b](9064d8b)) * Remove stale code ([#13445](#13445)) ([cc30fb0](cc30fb0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq Bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
🤖 I have created a release *beep* *boop* --- ## [2.1.6](plugins-source-stripe-v2.1.5...plugins-source-stripe-v2.1.6) (2023-08-30) ### Bug Fixes * **deps:** Update `github.com/cloudquery/arrow/go/v13` to `github.com/apache/arrow/go/v14` ([#13341](#13341)) ([feb8f87](feb8f87)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 5b83d4f ([#13203](#13203)) ([b0a4b8c](b0a4b8c)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.5.1 ([#13195](#13195)) ([a184c37](a184c37)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.5.2 ([#13262](#13262)) ([5c55aa3](5c55aa3)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.5.5 ([#13285](#13285)) ([e076abd](e076abd)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.5.6 ([#13345](#13345)) ([a995a05](a995a05)) * Remove stale code ([#13445](#13445)) ([cc30fb0](cc30fb0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caused by #13341