refactor: Clean up list tables method#13331
Merged
kodiakhq[bot] merged 2 commits intoAug 25, 2023
Merged
Conversation
erezrokah
commented
Aug 25, 2023
| where = fmt.Sprintf("AND pg_class.relname IN (%s)", c.inClause(include)) | ||
| } | ||
| if len(exclude) > 0 { | ||
| where = fmt.Sprintf("AND pg_class.relname NOT IN (%s)", c.inClause(exclude)) |
Member
Author
There was a problem hiding this comment.
I think there was a bug here. There should be a space between the include and exclude AND clauses
candiduslynx
approved these changes
Aug 25, 2023
kodiakhq Bot
pushed a commit
that referenced
this pull request
Aug 28, 2023
#### Summary Follow up to #13331. On AWS this means we search an array of ~600 items. Since at the moment we only have a single `MigrateTableBatch` call for all the tables, no point of having the `WHERE` clause (and even with multiple migrate batches might be faster just to query everything). See also https://www.postgresql.org/docs/current/arrays.html:  We can't really follow that tip though <!--
hermanschaaf
pushed a commit
that referenced
this pull request
Aug 29, 2023
#### Summary Follow up to #13331. On AWS this means we search an array of ~600 items. Since at the moment we only have a single `MigrateTableBatch` call for all the tables, no point of having the `WHERE` clause (and even with multiple migrate batches might be faster just to query everything). See also https://www.postgresql.org/docs/current/arrays.html:  We can't really follow that tip though <!--
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
excludewas always passed as an empty list. Also we can usetables.TableNames()