Skip to content

chore: remove make tasks for things moved out of the main repo#1226

Closed
skottler wants to merge 1 commit into
cloudquery:mainfrom
skottler:makefile-cleanup
Closed

chore: remove make tasks for things moved out of the main repo#1226
skottler wants to merge 1 commit into
cloudquery:mainfrom
skottler:makefile-cleanup

Conversation

@skottler
Copy link
Copy Markdown

@skottler skottler commented Aug 12, 2022

Summary

This cleans up some terraform-related tasks in the Makefile that are no longer relevant to this repo.


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Test locally on your own infrastructure
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@skottler skottler requested a review from yevgenypats as a code owner August 12, 2022 12:34
@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 12, 2022

@skottler is attempting to deploy a commit to the cloudquery Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cloudquery-versions ❌ Failed (Inspect) Aug 12, 2022 at 0:34AM (UTC)

@yevgenypats
Copy link
Copy Markdown
Contributor

Thanks!! Im actually working on cq v2 which removes a lot of unneeded code as well as adding new features here - #1201 (the makefile update is also in my pr so I wont merge this as I'll keep getting conflicts untill I'll be able to merge my PR in the next couple of weeks)

@yevgenypats yevgenypats self-assigned this Aug 13, 2022
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
…ger to v1.11.20 (#1226)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/aws/aws-sdk-go-v2/feature/s3/manager](https://togithub.com/aws/aws-sdk-go-v2) | require | patch | `v1.11.19` -> `v1.11.20` |

---

### Release Notes

<details>
<summary>aws/aws-sdk-go-v2</summary>

### [`v1.11.20`](https://togithub.com/aws/aws-sdk-go-v2/compare/feature/s3/manager/v1.11.19...feature/s3/manager/v1.11.20)

[Compare Source](https://togithub.com/aws/aws-sdk-go-v2/compare/feature/s3/manager/v1.11.19...feature/s3/manager/v1.11.20)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
@yevgenypats
Copy link
Copy Markdown
Contributor

Closing this, as I'll be taking care of this here shortly - #1201.

Thanks ! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants