Skip to content

Refactor/no diags#1139

Closed
yevgenypats wants to merge 5 commits into
mainfrom
refactor/no_diags
Closed

Refactor/no diags#1139
yevgenypats wants to merge 5 commits into
mainfrom
refactor/no_diags

Conversation

@yevgenypats
Copy link
Copy Markdown
Contributor

@yevgenypats yevgenypats commented Jul 24, 2022

WIP. This is going to be a re-write of a lot of parts of CloudQuery Core.

  1. No diags -> back to standard go err handling.
  2. too many abstraction layers then no one uses (probably left over from SaaS) which introduce callback hell and same structs passing deep with tests testing the same functionality over and over again. In general a good rule of thumb is KISS over DRY.

This just compiles and Im going to add some of the code slowly back until we have all the functionality together with cobra+viper.


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@yevgenypats yevgenypats requested review from disq and roneli July 24, 2022 19:22
@yevgenypats yevgenypats marked this pull request as ready for review July 24, 2022 19:22
@yevgenypats yevgenypats requested a review from a team July 24, 2022 19:22
@yevgenypats yevgenypats marked this pull request as draft July 24, 2022 19:22
@yevgenypats
Copy link
Copy Markdown
Contributor Author

This moved to #1201

@yevgenypats yevgenypats deleted the refactor/no_diags branch August 15, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant