fix(digitalocean-resources): Remove relational tables from top level list#7632
Merged
kodiakhq[bot] merged 2 commits intoFeb 2, 2023
Merged
Conversation
candiduslynx
approved these changes
Feb 2, 2023
disq
approved these changes
Feb 2, 2023
kodiakhq Bot
pushed a commit
that referenced
this pull request
Feb 7, 2023
🤖 I have created a release *beep* *boop* --- ## [4.1.4](plugins-source-digitalocean-v4.1.3...plugins-source-digitalocean-v4.1.4) (2023-02-07) ### Bug Fixes * **deps:** Update golang.org/x/exp digest to f062dba ([#7531](#7531)) ([59d5575](59d5575)) * **deps:** Update google.golang.org/genproto digest to 1c01626 ([#7533](#7533)) ([c549c27](c549c27)) * **deps:** Update module github.com/avast/retry-go/v4 to v4.3.2 ([#7542](#7542)) ([7219fc0](7219fc0)) * **deps:** Update module github.com/aws/aws-sdk-go-v2 to v1.17.4 ([#7652](#7652)) ([2196050](2196050)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.18.12 ([#7653](#7653)) ([59daf42](59daf42)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/feature/ec2/imds to v1.12.22 ([#7655](#7655)) ([4e56621](4e56621)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/internal/ini to v1.3.29 ([#7659](#7659)) ([60f15d7](60f15d7)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/internal/v4a to v1.0.19 ([#7660](#7660)) ([9035012](9035012)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.33.0 ([#7595](#7595)) ([c5adc75](c5adc75)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.33.1 ([#7614](#7614)) ([2fe665c](2fe665c)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.34.0 ([#7719](#7719)) ([6a33085](6a33085)) * **digitalocean-resources:** Remove relational tables from top level list ([#7632](#7632)) ([db53d6d](db53d6d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes https://github.com/cloudquery/cloudquery-issues/issues/470 (internal issue).
2 relational tables were also configured as top level ones causing them to fail when we try to get the parent.
I removed them from the top level tables list, and also made all relational tables functions private to avoid similar issues.
This is not a breaking change as those tables still exist, and if someone is referencing them we know to sync the parent first