feat: Check for slashes in policy#561
Merged
Merged
Conversation
It is an error if a policy or check label (name) contains a slash. Differentiate between errors and warnings during loading of config file. Reverse return values of setupCheckFetchDatabase to comply with Go style of "error comes last".
zagronitay
previously requested changes
Mar 29, 2022
TinLe
pushed a commit
to TinLe/cloudquery
that referenced
this pull request
Apr 7, 2022
* upstream/main: feat: Purge stale data (cloudquery#565) feat: Add '--disable-fetch-check' flag (cloudquery#567) chore: Sync form .github (cloudquery#569) feat: Drift: Improvements (cloudquery#563) fix: Added error when connection configuration is not set (cloudquery#476) feat: Check for slashes in policy (cloudquery#561)
This was referenced May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is an error if a policy or check label (name) contains a slash.
Differentiate between errors and warnings during loading of config file.
Reverse return values of setupCheckFetchDatabase to comply with Go style
of "error comes last".